netdev - Re: [PATCH] net: Default UDP and UNIX diag to 'n'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F31292F.2090503@parallels.com>
Date:	Tue, 07 Feb 2012 17:37:51 +0400
From:	Pavel Emelyanov <xemul@...allels.com>
To:	Anisse Astier <anisse@...ier.eu>
CC:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH] net: Default UDP and UNIX diag to 'n'.

>> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
>> index 1a8f93b..43e1439 100644
>> --- a/net/ipv4/Kconfig
>> +++ b/net/ipv4/Kconfig
>> @@ -410,8 +410,12 @@ config INET_TCP_DIAG
>>  	def_tristate INET_DIAG
>>  
>>  config INET_UDP_DIAG
>> +	tristate "UDP: socket monitoring interface"
>>  	depends on INET_DIAG
>> -	def_tristate INET_DIAG && IPV6
> This broke earlier patch 
> b872a2371ffd13e6d83423ef621a707df4c158ac "udp_diag: Make it module when ipv6 is a module",
> which brings back the compilation error when compiling linus master (v3.3-rc2+):
> 
> net/built-in.o: In function `udp_dump_one':
> udp_diag.c:(.text+0x59852): undefined reference to `__udp6_lib_lookup'
> 
> 
>> +	default n
>> +	---help---
>> +	  Support for UDP socket monitoring interface used by the ss tool.
>> +	  If unsure, say Y.
>>  

I assume you have CONFIG_IPV6=m and CONFIG_INET_UDP_DIAG=y, right?
This one should fix the issue, you'll not be able to set it to Y when
IPV6 is M.


[PATCH] udp_diag: Add dependency on IPV6

Signed-off-by: Pavel Emelyanov <xemul@...allels.com>

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index aa2a2c7..55d39a4 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -409,7 +409,7 @@ config INET_TCP_DIAG
 
 config INET_UDP_DIAG
 	tristate "UDP: socket monitoring interface"
-	depends on INET_DIAG
+	depends on INET_DIAG && IPV6
 	default n
 	---help---
 	  Support for UDP socket monitoring interface used by the ss tool.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html