netdev - Re: [PATCH] net: Default UDP and UNIX diag to 'n'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120207183911.4dd65ac8@destiny.ordissimo>
Date:	Tue, 7 Feb 2012 18:39:11 +0100
From:	Anisse Astier <anisse@...ier.eu>
To:	David Miller <davem@...emloft.net>
Cc:	xemul@...allels.com, netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH] net: Default UDP and UNIX diag to 'n'.

On Tue, 07 Feb 2012 12:29:31 -0500 (EST), David Miller <davem@...emloft.net> wrote :

> From: Pavel Emelyanov <xemul@...allels.com>
> Date: Tue, 07 Feb 2012 17:37:51 +0400
> 
> > @@ -409,7 +409,7 @@ config INET_TCP_DIAG
> >  
> >  config INET_UDP_DIAG
> >  	tristate "UDP: socket monitoring interface"
> > -	depends on INET_DIAG
> > +	depends on INET_DIAG && IPV6
> 
> This needs to be something like "INET_DIAG && (IPV6 || IPV6=n)"

Yes, this works better. This is the right solution.

Tested-by: Anisse Astier <anisse@...ier.eu>

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index aa2a2c7..d183262 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -409,7 +409,7 @@ config INET_TCP_DIAG
 
 config INET_UDP_DIAG
        tristate "UDP: socket monitoring interface"
-       depends on INET_DIAG
+       depends on INET_DIAG && (IPV6 || IPV6=n)
        default n
        ---help---
          Support for UDP socket monitoring interface used by the ss tool.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html