netdev - Re: [PATCH net-next] gro: more generic L2 header check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120208.155027.599792363539233740.davem@davemloft.net>
Date:	Wed, 08 Feb 2012 15:50:27 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ogerlitz@...lanox.com, sean.hefty@...el.com,
	herbert@...dor.hengli.com.au, linux-rdma@...r.kernel.org,
	shlomop@...lanox.com, roland@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] gro: more generic L2 header check

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 08 Feb 2012 19:51:50 +0100

> Shlomo Pongratz reported GRO L2 header check was suited for Ethernet
> only, and failed on IB/ipoib traffic.
> 
> He provided a patch faking a zeroed header to let GRO aggregates frames.
> 
> Roland Dreier, Herbert Xu, and others suggested we change GRO L2 header
> check to be more generic, ie not assuming L2 header is 14 bytes, but
> taking into account hard_header_len.
> 
> __napi_gro_receive() has special handling for the common case (Ethernet)
> to avoid a memcmp() call and use an inline optimized function instead.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Reported-by: Shlomo Pongratz <shlomop@...lanox.com>
> Cc: Roland Dreier <roland@...nel.org>
> Cc: Or Gerlitz <ogerlitz@...lanox.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Tested-by: Sean Hefty <sean.hefty@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html