netdev - Re: [PATCH net-next] gro: more generic L2 header check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZLLteDbm0prTN3-npubtFun=kO2DYT7ea=E-HyJ84gaiA@mail.gmail.com>
Date:	Wed, 8 Feb 2012 23:49:43 +0200
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, ogerlitz@...lanox.com,
	sean.hefty@...el.com, herbert@...dor.hengli.com.au,
	linux-rdma@...r.kernel.org, shlomop@...lanox.com,
	roland@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] gro: more generic L2 header check

On Wed, Feb 8, 2012 at 11:31 PM, David Miller <davem@...emloft.net> wrote:
> From: Or Gerlitz <or.gerlitz@...il.com>

>> Hi Dave, for correct operation / future bisection, you should 1st
>> apply Roland's patch which reduces the hard header len advertized by
>> ipoib to be only the size of the ipoib header without that 20 bytes
>> headroom, else the gro memcmp will be issued on the ipoib header and
>> then 20 bytes of the ip header, kind of back to square one...

> I did.

Yep, I missed your earlier response to Roland's patch. So a question
here, how would you recommend to get that out... since the fix for the
problem includes two patches to core networking and one patch to
ipoib, we can't just ship a patch to ipoib which people can apply
build against their kernels. You've placed this work in net-next and
not net, so I assume we should wait for 3.4-rc1 and then push to
-stable? any other method to use here that you can recommend? thanks,

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html