netdev - Re: [PATCH net-next] gro: more generic L2 header check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZ+SyGsDpnK89wNWtBn4Jdzc2tg1diKjbHSv=n75XiG+ug@mail.gmail.com>
Date:	Thu, 9 Feb 2012 01:20:46 +0200
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, ogerlitz@...lanox.com,
	sean.hefty@...el.com, herbert@...dor.hengli.com.au,
	linux-rdma@...r.kernel.org, shlomop@...lanox.com,
	roland@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] gro: more generic L2 header check

On Thu, Feb 9, 2012 at 1:09 AM, David Miller <davem@...emloft.net> wrote:
> I don't think this is an appropriate bug fix at all.

I'm not sure to understand

> Apparently this problem has existed since day one and the world has
> kept on spinning meanwhile.

Dave, the bug was introduced on 2.6.38 when LRO was removed from IPoIB
and GRO added, so users who run distributions containing pre 2.6.38
kernels don't hit the bug.

So with the world keep spinning, GRO becomes critical when throwing
ipoib into the virtualization space, as except for LRO being
deprecated, its not supported by the virtualization stack (e.g the
bridge), and here GRO should come into play, and will, after the
fix... BTW - ipoib surely can't be plugged to bridge/macvtap as is,
but this is different story to cope with, now one less obstacle, GRO
works!

Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html