netdev - Re: [RFC 2/2] e1000e: Support RXALL feature flag.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Feb 2012 01:06:42 +0100
From:	Michał Mirosław <mirqus@...il.com>
To:	greearb@...delatech.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC 2/2] e1000e: Support RXALL feature flag.

2012/2/8  <greearb@...delatech.com>:
> From: Ben Greear <greearb@...delatech.com>
>
> This allows the NIC to receive all frames available, including
> those with bad FCS, un-matched vlans, ethernet control frames,
> and more.
>
> Tested by sending frames with bad FCS.

This should probably mark the bad packets somehow, so they are not
passed up the stack and mixed with correct traffic.

[...]
> @@ -2996,6 +3001,25 @@ static void e1000_setup_rctl(struct e1000_adapter *adapter)
>                ew32(PSRCTL, psrctl);
>        }
>
> +       /* This is useful for sniffing bad packets. */
> +       if (adapter->netdev->features & NETIF_F_RXALL) {
> +               rctl |= (E1000_RCTL_SBP | /* Receive bad packets */
> +                        E1000_RCTL_UPE | /* RX all Unicast Pkts */
> +                        E1000_RCTL_MPE | /* RX all Mcast Pkts */
> +                        E1000_RCTL_BAM | /* RX All Bcast Pkts Pkts */
> +                        E1000_RCTL_PMCF); /* RX All MAC Ctrl Pkts */
> +
> +               rctl &= ~(E1000_RCTL_VFE | /* Disable VLAN filter */
> +                         E1000_RCTL_DPF | /* Allow filtered pause */
> +                         E1000_RCTL_CFIEN); /* Dis VLAN CFIEN Filter */
> +               /* disable VLAN tagging/striping */
> +               /* SKIP This, it also affects transmit side and
> +                  screws up VLANs --Ben. */
> +               /* ctrl = er32(CTRL); */
> +               /* ctrl &= ~E1000_CTRL_VME; */
> +               /* ew32(CTRL, ctrl); */
> +       }
> +
[...]

Looks like it can be enabled independently of promisc mode: rx-all +
no-promisc would receive only bad packets destined for this host.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html