netdev - RE: [RFC PATCH] rtnetlink: Add filter for VF info dump requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C5551D9AAB213A418B7FD5E4A6F30A0702F87530@ORSMSX106.amr.corp.intel.com>
Date:	Thu, 9 Feb 2012 18:57:26 +0000
From:	"Rose, Gregory V" <gregory.v.rose@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [RFC PATCH] rtnetlink: Add filter for VF info dump requests

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Thursday, February 09, 2012 10:50 AM
> To: Rose, Gregory V
> Cc: netdev@...r.kernel.org
> Subject: Re: [RFC PATCH] rtnetlink: Add filter for VF info dump requests
> 
> From: "Rose, Gregory V" <gregory.v.rose@...el.com>
> Date: Thu, 9 Feb 2012 18:45:59 +0000
> 
> >> -----Original Message-----
> >> From: David Miller [mailto:davem@...emloft.net]
> >> Sent: Thursday, February 09, 2012 10:44 AM
> >> To: Rose, Gregory V
> >> Cc: netdev@...r.kernel.org
> >> Subject: Re: [RFC PATCH] rtnetlink: Add filter for VF info dump
> requests
> >>
> >> From: "Rose, Gregory V" <gregory.v.rose@...el.com>
> >> Date: Thu, 9 Feb 2012 16:25:31 +0000
> >>
> >> > That will change the semantics to the 'ip link show' command quite a
> >> bit.
> >>
> >> I think that's rubbish.
> >>
> >> You can make "ip link show" do whatever you want, including setting all
> >> feature bits in getlink requests, which will preserve existing
> behavior.
> >
> > But there will be a change to the command line semantics no?  How do
> > I communicate which feature bits to set in getlink requests
> > otherwise?
> 
> Make "ip" internally default to "all" feature bits.  I don't really
> understand what the consternation is.  Right now, that's what happens,
> the kernel dumps all the attributes including "VF" stuff.
> 

I'm sure the consternation on my part is that I had thought you wanted the feature bits to default to none.  You said this at one point:

---------
It seems clear that we must, at this point, turn off VF attributes by default.
---------

I'm sorry if I seem obtuse but I'm completely confused now.

And if we default all the feature bits for VFs, macvlans, etc. to on then it seems to me there has to be some way to turn them off from user space.

- Greg

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html