netdev - Re: newbie: phy platform interrupt config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKWjMd66rTzM7AipQZsu-c0jDSNw_=CFHnN1Mms4WQp_4aaFWA@mail.gmail.com>
Date:	Thu, 9 Feb 2012 00:29:15 -0600
From:	Andy Fleming <afleming@...il.com>
To:	Tim Sander <tim01@....tu-darmstadt.de>
Cc:	netdev@...r.kernel.org, Andy Fleming <afleming@...escale.com>,
	"David S. Miller" <davem@...emloft.net>,
	Richard Cochran <richard.cochran@...cron.at>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Eric Dumazet <eric.dumazet@...il.com>,
	David Decotigny <decot@...gle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: newbie: phy platform interrupt config

On Tue, Jan 24, 2012 at 8:37 AM, Tim Sander <tim01@....tu-darmstadt.de> wrote:
> Hi
>
> I would like to set the interrupt for the phy on the i.mx35 pcm43 in the file
> arch/arm/mach-imx/mach-pcm043.c. Unfortunatly i didn't find a way to specify
> it. So i want to set the field (struct phy_device*)->irq.
>
> What i managed so far is to request the gpio for the interrupt:
> #define IMX_PHY_IRQ IMX_GPIO_NR(2,7)
> gpio_request(IMX_PHY_IRQ, "FEC PHY irq");
> gpio_direction_input(IMX_PHY_IRQ);
>
> Now i guess the result of "gpio_to_irq(IMX_PHY_IRQ)" should go into some kind
> of argument to imx35_add_fec(pdata) which is a macro
> imx_add_fec(&imx35_fec_data, pdata).
> pdata is of type (?) struct fec_platform_data which contains phy_interface_t
> and unsigned char array. So i don't see a way to set the phy interrupt there.
>
> I tried search for a driver which set the phy irq but i didn't find any and
> setting the phy in the phy_fixup function is also not working since the
> interrupt seems not get registered when opening the device.
>
> So how do i set the phy interrupt line in the platform file?

Look in drivers/of/of_mdio.c.

It's the job of the mdio driver to set the IRQs for the device. I
don't honestly know why I designed it that way. I suspect it's because
the MDIO controller's driver is the entity most likely to communicate
directly with the platform code.

So wherever you set up your mdio bus, set the IRQs for all the PHYs on
the bus there.

Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html