netdev - RE: [patch] netxen_nic: signedness bug in netxen_md_entry_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <13A253B3F9BEFE43B93C09CF75F63CAA81A886ECD2@MNEXMB1.qlogic.org>
Date:	Thu, 9 Feb 2012 01:27:58 -0600
From:	Rajesh Borundia <rajesh.borundia@...gic.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Sony Chacko <sony.chacko@...gic.com>
CC:	netdev <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk()

Thanks Dan for fixing this.

Rajesh
________________________________________
From: Dan Carpenter [dan.carpenter@...cle.com]
Sent: Wednesday, February 08, 2012 2:53 PM
To: Sony Chacko
Cc: Rajesh Borundia; netdev; kernel-janitors@...r.kernel.org
Subject: [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk()

"esize" should be signed because it can be negative here.  For example,
when we call it in netxen_parse_md_template(), it could be -1 from the
return value of netxen_md_L2Cache().

Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
index 0a81228..6f37470 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c
@@ -2354,7 +2354,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter,
 */

 static int netxen_md_entry_err_chk(struct netxen_adapter *adapter,
-                               struct netxen_minidump_entry *entry, u32 esize)
+                               struct netxen_minidump_entry *entry, int esize)
 {
        if (esize < 0) {
                entry->hdr.driver_flags |= NX_DUMP_SKIP;


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html