lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4F3382CF.8090302@atmel.com> Date: Thu, 09 Feb 2012 09:24:47 +0100 From: Nicolas Ferre <nicolas.ferre@...el.com> To: Danny Kukawka <danny.kukawka@...ect.de> CC: "David S. Miller" <davem@...emloft.net>, Danny Kukawka <dkukawka@...e.de>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>, Jamie Iles <jamie@...ieiles.com> Subject: Re: [PATCH 09/50] Cadence MACB: use dev_hw_addr_random() instead of random_ether_addr() On 02/08/2012 10:10 PM, Danny Kukawka : > Use dev_hw_addr_random() instead of calling random_ether_addr() > to set addr_assign_type correctly to NET_ADDR_RANDOM. > > Signed-off-by: Danny Kukawka <danny.kukawka@...ect.de> Danny, You can add my "Acked-by" even if you rework this series... Acked-by: Nicolas Ferre <nicolas.ferre@...el.com> Thanks, best regards, > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 2320068..3ee8d79 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -87,7 +87,7 @@ static void __init macb_get_hwaddr(struct macb *bp) > memcpy(bp->dev->dev_addr, addr, sizeof(addr)); > } else { > netdev_info(bp->dev, "invalid hw address, using random\n"); > - random_ether_addr(bp->dev->dev_addr); > + dev_hw_addr_random(bp->dev, bp->dev->dev_addr); > } > } > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists