netdev - Re: [net 3/8] ixgbe: fix vf lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1328778375.6576.3.camel@jtkirshe-mobl>
Date:	Thu, 09 Feb 2012 01:06:15 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	gregory.v.rose@...el.com, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com, stable@...r.kernel.org
Subject: Re: [net 3/8] ixgbe: fix vf lookup

On Wed, 2012-02-08 at 18:33 -0500, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Wed,  8 Feb 2012 01:36:33 -0800
> 
> > -             if (pvfdev->devfn == vf_devfn)
> > +             if (pvfdev->devfn == vf_devfn &&
> > +                             (pvfdev->bus->number >=
> pdev->bus->number))
> 
> Come on.... do you look at these patches at all?
> 
> I don't think you did, because this kind of code formatting stuff
> sticks out like a sore thumb. 

Your right, I over-looked this, and it is especially bad since I caught
the problem with the igb patch (which was right before this one).  I
remember thinking that I need to make sure the ixgbe patch did not have
the same formatting issue.  But completely forgot before I applied the
patch.


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)