| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.DEB.2.01.1202091024250.8085@pmeerw.net> Date: Thu, 9 Feb 2012 10:38:15 +0100 (CET) From: Peter Meerwald <pmeerw@...erw.net> To: David Miller <davem@...emloft.net> cc: netdev@...r.kernel.org Subject: Re: [PATCH 1/2] smsc95xx: add module parameter to turn off NIC status leds Hello David, > > add module parameter to allow to turn off NIC status leds (link, > > speed, activity); blinking LEDs are annoying outside the server room :) > No. Create a generic mechanism, perhaps via ethtool, for users to > configure something like this. > Otherwise the next driver that wants to provide this kind of knob > will add yet another module parameter with yet another name, and > this kind of ad-hoc set of interfaces absolutely sucks for users. I am not sure how many NICs provide that functionality, so a specific knob seemed reasonable I had a look at ethtool, there are ETHTOOL_GFLAGS and ETHTOOL_GPFLAGS (and the respective setters) which could be used -- but noone seems to use those for any purpose a private flag for LED control (via ETHTOOL_GPFLAGS) is pretty much the same knob as a module parameter, so not an option so the remaining option is to add something like ETHTOOL_GLEDCONTROL / ETHTOOL_SLEDCONTROL with likely only one user (smsc95xx) regards, p. -- Peter Meerwald +43-664-2444418 (mobile) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists