lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <201202091555.15071.oliver@neukum.org> Date: Thu, 9 Feb 2012 15:55:14 +0100 From: Oliver Neukum <oliver@...kum.org> To: Bjørn Mork <bjorn@...k.no> Cc: Danny Kukawka <danny.kukawka@...ect.de>, Danny Kukawka <dkukawka@...e.de>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, linux-usb@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 37/50] usbnet: set addr_assign_type if random_ether_addr() used Am Donnerstag, 9. Februar 2012, 07:57:42 schrieb Bjørn Mork: > > Don't you set the flag too early here? By that time we don't know > > whether the device provides a real MAC, do we? > > Maybe it makes sense to set it here anyway since usbnet provides this > default random address, and let the minidrivers which set a real mac > also clear the flag? But in that case the patch need to clear the flag > everywhere a minidriver currently updates the address. > Doable, but where is the benefit? It seems better to me to make an effort to guess as well as possible in the common code. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists