netdev - Re: r8169 crash (probably my fault) in 3.3.0-rc1+ (net-next)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Feb 2012 09:09:37 -0800
From:	Ben Greear <greearb@...delatech.com>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	netdev <netdev@...r.kernel.org>
Subject: Re: r8169 crash (probably my fault) in 3.3.0-rc1+ (net-next)

On 02/10/2012 01:30 AM, Francois Romieu wrote:
> Ben Greear<greearb@...delatech.com>  :
> [...]
>> I am hacking on the 8169 code, (adding RX-ALL and RX-FCS support on top
>> of my previously posted patches) so this could easily be my fault..
>> but just in case someone else has seen it, please let me know....
>
> I have never met it before. Neither does the web.
>
> Are you hacking against davem's -next branch ?

Yes.  I was testing the attached patch, and when I enabled the rx-fcs, it crashed
shortly after.  So, my changes must be bad somehow...

Probably something to do with pkt_size being 4 bytes larger when
rx-fcs is enabled (I was hoping that would grab the FCS, as similar
logic seems to work fine in 8139too...)

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com


View attachment "rtl.patch" of type "text/x-patch" (2835 bytes)