netdev - Re: [PATCH 2/2] tcp: fix range tcp_shifted_skb() passes to tcp_sacktag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120213.010115.212510396679401761.davem@davemloft.net>
Date:	Mon, 13 Feb 2012 01:01:15 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ncardwell@...gle.com
Cc:	netdev@...r.kernel.org, ilpo.jarvinen@...sinki.fi,
	nanditad@...gle.com, ycheng@...gle.com, therbert@...gle.com,
	subramanian.vijay@...il.com
Subject: Re: [PATCH 2/2] tcp: fix range tcp_shifted_skb() passes to
 tcp_sacktag_one()

From: Neal Cardwell <ncardwell@...gle.com>
Date: Sun, 12 Feb 2012 23:37:10 -0500

> Fix the newly-SACKed range to be the range of newly-shifted bytes.
> 
> Previously - since 832d11c5cd076abc0aa1eaf7be96c81d1a59ce41 -
> tcp_shifted_skb() incorrectly called tcp_sacktag_one() with the start
> and end sequence numbers of the skb it passes in set to the range just
> beyond the range that is newly-SACKed.
> 
> This commit also removes a special-case adjustment to lost_cnt_hint in
> tcp_shifted_skb() since the pre-existing adjustment of lost_cnt_hint
> in tcp_sacktag_one() now properly handles this things now that the
> correct start sequence number is passed in.
> 
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>

Looks great, applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html