netdev - Re: [PATCH 1/2] bluetooth: Use more current logging styles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329117706.28848.55.camel@aeonflux>
Date:	Mon, 13 Feb 2012 08:21:46 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Joe Perches <joe@...ches.com>
Cc:	"Gustavo F. Padovan" <padovan@...fusion.mobi>,
	"David S. Miller" <davem@...emloft.net>,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] bluetooth: Use more current logging styles

Hi Joe,

> > Why is this a good thing?
> 
> It's more similar to the rest of the <foo>_<level> uses.
> Other than that, it's a little smaller.
> 
> > And in your patch we have bt_err not having \n\n in the end.
> 
> There shouldn't be a newline at all with the
> actual functions bt_err or bt_info except
> at the uses.

then you might wanna read your patch again ;)

> This is the style used in pr_<level> so that
> it becomes possible to use pr_cont.

Since we don't have a bt_cont, I don't see why bother changing this
right now.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html