netdev - Re: bonding with 3c59x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120214.144335.558771219791311889.davem@davemloft.net>
Date:	Tue, 14 Feb 2012 14:43:35 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	klassert@...hematik.tu-chemnitz.de
Cc:	jdelvare@...e.de, eric.dumazet@...il.com, fubar@...ibm.com,
	netdev@...r.kernel.org
Subject: Re: bonding with 3c59x driver

From: Steffen Klassert <klassert@...hematik.tu-chemnitz.de>
Date: Tue, 14 Feb 2012 14:34:18 +0100

> On Tue, Feb 14, 2012 at 01:50:57PM +0100, Jean Delvare wrote:
>> 
>> > We could have a 5 sec timer in case device is a slave.
>> > 
>> > diff --git a/drivers/net/ethernet/3com/3c59x.c
>> >  b/drivers/net/ethernet/3com/3c59x.c index 1282f04..e463d10 100644
>> > --- a/drivers/net/ethernet/3com/3c59x.c
>> > +++ b/drivers/net/ethernet/3com/3c59x.c
>> > @@ -1841,7 +1841,7 @@ vortex_timer(unsigned long data)
>> >  		ok = 1;
>> >  	}
>> > 
>> > -	if (!netif_carrier_ok(dev))
>> > +	if (dev->flags & IFF_SLAVE || !netif_carrier_ok(dev))
>> >  		next_tick = 5*HZ;
>> > 
>> >  	if (vp->medialock)
>> 
>> Yes I think this makes a lot of sense. If you send this upstream you can 
>> add:
>> 
>> Acked-by: Jean Delvare <jdelvare@...e.de>
>> 
> 
> I'm fine with this too.

Eric, please submit this formally.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html