netdev - RE: [PATCH] bnx2x: preserve net device stats across reload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <FD96C117992C584DBC47231B1EB6F556B00B33AF39@SJEXCHCCR02.corp.ad.broadcom.com>
Date:	Mon, 13 Feb 2012 23:08:48 -0800
From:	"Yuval Mintz" <yuvalmin@...adcom.com>
To:	"mschmidt@...hat.com" <mschmidt@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
cc:	"Eilon Greenstein" <eilong@...adcom.com>,
	"Yaniv Rosner" <yaniv.rosner@...adcom.com>,
	"Dmitry Kravkov" <dmitry@...adcom.com>
Subject: RE: [PATCH] bnx2x: preserve net device stats across reload

> The network device statistics were reset to zero when the bnx2x driver
> reloaded the NIC, such as when changing the MTU.
> 
> To preserve the statistics across reloads, save the current values when
> unloading. Add the saved values to the values read currently from the
> hardware when updating the stats. Forget the saved values if the reason
> for unloading is that the device is going down.

Thanks for this patch -  indeed there is currently a problem with statistics 
reset during inner reloads such as MTU changes. 

However, notice that keeping the net_device_stats statistics consistent 
across such changes is only a very partial solution, since most of the 
statistics will still be reset. E.g., bp->eth_stats will be reset, causing ethtool 
to output zero statistics after such an inner reload.

I'm currently working on a patch to fix this issue. Since my patch will make
the statistics in bnx2x_eth_stats consistent after an inner reload, 
the changes made here will be unrequired, since all the net_device_stats 
are direct products of bnx2x_eth_stats (with the exception of one field).

I will try to submit it later on today.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html