netdev - Re: [PATCH 1/2] r8169: Enable WOL from Magic Packet by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120214.223746.419009242484406948.davem@davemloft.net>
Date:	Tue, 14 Feb 2012 22:37:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	snanda@...omium.org
Cc:	romieu@...zoreil.com, rjw@...k.pl, hayeswang@...ltek.com,
	netdev@...r.kernel.org, linux-pm@...ts.linux-foundation.org
Subject: Re: [PATCH 1/2] r8169: Enable WOL from Magic Packet by default

From: Sameer Nanda <snanda@...omium.org>
Date: Tue, 14 Feb 2012 17:00:04 -0800

> On Tue, Feb 14, 2012 at 4:13 PM, Francois Romieu <romieu@...zoreil.com> wrote:
>> Sameer Nanda <snanda@...omium.org> :
>>> Set the WOL config registers to only enable WOL from magic packet by
>>> default. Without this change in place, the WOL config register
>>> settings on warm reboot come up in an inconsistent state since these
>>> registers don't get reset on a warm reboot.
>>
>> I am not completely convinced, especially as the change of behavior
>> could be noticed.
> 
> Agreed that this change could be noticed.  Maybe a module parameter
> might be a better way to handle this?

Please no random module parameters, something ethtool based is
what you should shoot for.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html