netdev - [PATCH 0/5] Delay selecting alternate setting in CDC NCM until network interface is raised

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1329317261-3406-1-git-send-email-toby.gray@realvnc.com>
Date:	Wed, 15 Feb 2012 14:47:36 +0000
From:	Toby Gray <toby.gray@...lvnc.com>
To:	Toby Gray <tg@...lvnc.com>, Oliver Neukum <oliver@...kum.name>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org
Cc:	netdev@...r.kernel.org, alexey.orishko@...il.com,
	Toby Gray <toby.gray@...lvnc.com>
Subject: [PATCH 0/5] Delay selecting alternate setting in CDC NCM until network interface is raised

This patch series moves the setting of the alternate setting used
for the CDC NCM data interface until the network interface is
raised. Before this patch series the CDC NCM driver would select
the alternate setting which allows data to be sent and received
as soon as the device was probed.

While the previous behaviour was not against the CDC NCM
specification it is problematic with some CDC NCM devices,
e.g. Nokia 701 Mobile Telephone. These devices will only send the
network connection status notification to the host if the control
interrupt endpoint is read from within a few seconds of the data
enabled alternate setting being selected.

This behaviour means that the network connection notification
would never be received and so the network interface would stay
in a disconnected state indefinitely, unless the interface was
marked as 'up' almost immediately after the CDC NCM device was
probed.

Toby Gray (5):
  usb: cdc-ncm: Change alternate setting magic numbers into #defines
  usb: cdc-ncm: Set altsetting only when network interface is opened
  usb: usbnet: Allow drivers using usbnet to specify maximum packet
    size
  usb: usbnet: Add validation of dev->maxpacket to usbnet
  usb: cdc-ncm: Allow NCM driver to determine dev->maxpacket

 drivers/net/usb/cdc_ncm.c |   46 ++++++++++++++++++++++++++++++++++++--------
 drivers/net/usb/usbnet.c  |    7 +++++-
 2 files changed, 43 insertions(+), 10 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html