netdev - Re: [PATCH] netem: fix unwanted reordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1329372786.5646.7.camel@edumazet-laptop>
Date:	Thu, 16 Feb 2012 07:13:06 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] netem: fix unwanted reordering

Le jeudi 16 février 2012 à 06:49 +0100, Eric Dumazet a écrit :
> commit 50612537e9 (netem: fix classful handling) added in typo in
> netem_dequeue() :
> 
> After checking skb at the head of tfifo queue for time constraints, it
> dequeues tail skb, thus adding unwanted reordering.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> ---
>  net/sched/sch_netem.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Please dont apply this patch, there is a 2nd issue I must fix as well

(qdisc stats are updated twice)




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html