netdev - Re: [PATCH v2 01/10] au1000_eth: use eth_hw_addr_random() instead of random_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120217.155930.1401463574783963868.davem@davemloft.net>
Date:	Fri, 17 Feb 2012 15:59:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	danny.kukawka@...ect.de
Cc:	dkukawka@...e.de, jeffrey.t.kirsher@...el.com, jpirko@...hat.com,
	mcuos.com@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/10] au1000_eth: use eth_hw_addr_random() instead
 of random_ether_addr()

From: Danny Kukawka <danny.kukawka@...ect.de>
Date: Fri, 17 Feb 2012 16:43:22 +0100

> Use eth_hw_addr_random() instead of calling random_ether_addr()
> to set addr_assign_type correctly to NET_ADDR_RANDOM.
> 
> v2: adapt to eth_hw_addr_random()
> 
> Signed-off-by: Danny Kukawka <danny.kukawka@...ect.de>

Please don't shit up the comments:

> -	/* set a random MAC now in case platform_data doesn't provide one */
 ...
> +			/*set a random MAC since no valid provided by platform_data*/

You had to work to make that comment look worse than it originally
did in the code, spaces around the sentence and if you can be so
bothered capitalize sentences and put proper punctionation at the
end.

I took care of this, but I will not next time.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html