netdev - Re: [PATCH v2 08/10] ethoc: set addr_assign_type if random_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120217.160246.1152435667025162438.davem@davemloft.net>
Date:	Fri, 17 Feb 2012 16:02:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	danny.kukawka@...ect.de
Cc:	dkukawka@...e.de, adobriyan@...il.com,
	paul.gortmaker@...driver.com, richard.cochran@...cron.at,
	jkosina@...e.cz, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 08/10] ethoc: set addr_assign_type if
 random_ether_addr() used

From: Danny Kukawka <danny.kukawka@...ect.de>
Date: Fri, 17 Feb 2012 16:43:29 +0100

> Set addr_assign_type correctly to NET_ADDR_RANDOM in case
> a random MAC address was generated and assigned to the netdevice.
> 
> Fixed ethoc_set_mac_address() to check if the given mac
> address is valid and set also dev_addr of the net_device.
> Check also the return value of ethoc_set_mac_address() in
> ethoc_probe().
> 
> Reset the state to NET_ADDR_PERM as soon as the MAC get
> changed via .ndo_set_mac_address.
> 
> v2: set net_device->dev_addr in ethoc_set_mac_address(),
>     check if given address is valid
> 
> Signed-off-by: Danny Kukawka <danny.kukawka@...ect.de>

Applied, but more coding style problems:

> +	if(!is_valid_ether_addr(mac))

Come on, "if[SPACE](..." always.

> +        

Trailing whitespace.

> +	if (ret) {
> +		dev_err(&netdev->dev, "failed to set MAC address\n");
> +		goto error;
> +	}
> +	

More tailing whitespace.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html