netdev - Re: [PATCH v2 04/10] xilinx ll_temac: use eth_hw_addr_random() instead of random_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120217.160056.468165222350582907.davem@davemloft.net>
Date:	Fri, 17 Feb 2012 16:00:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	danny.kukawka@...ect.de
Cc:	dkukawka@...e.de, sfr@...b.auug.org.au, ricardo.ribalda@...il.com,
	thomas@...3r.de, richard.cochran@...cron.at,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 04/10] xilinx ll_temac: use eth_hw_addr_random()
 instead of random_ether_addr()

From: Danny Kukawka <danny.kukawka@...ect.de>
Date: Fri, 17 Feb 2012 16:43:25 +0100

> Use eth_hw_addr_random() instead of calling random_ether_addr()
> to set addr_assign_type correctly to NET_ADDR_RANDOM.
> 
> Reset the state to NET_ADDR_PERM as soon as the MAC get
> changed via .ndo_set_mac_address.
> 
> v2: reworked to prevent using an extra variable
> 
> Signed-off-by: Danny Kukawka <danny.kukawka@...ect.de>

Applied, but:

> +	else 

Trailing whitespace.  This isn't something you need to be a rocket
scientist to catch, the tools find it for you, as they did for me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html