netdev - Re: [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changes in arch/blackfin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201202171815.59846.vapier@gentoo.org>
Date:	Fri, 17 Feb 2012 18:15:57 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	Danny Kukawka <danny.kukawka@...ect.de>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Sonic Zhang <sonic.zhang@...log.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Bob Liu <bob.liu@...log.com>,
	uclinux-dist-devel@...ckfin.uclinux.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] adi: adapt to eth_hw_addr_random() and changes in arch/blackfin

On Friday 17 February 2012 05:57:54 Danny Kukawka wrote:
> On Freitag, 17. Februar 2012, Mike Frysinger wrote:
> > On Thu, Feb 16, 2012 at 12:09, Danny Kukawka wrote:
> > > +                       netdev_warn(ndev, "Setting Ethernet MAC to a
> > > random one\n"); +                       eth_hw_addr_random(ndev);
> > 
> > would it make sense to have the core dump the warning ?
> 
> Maybe. Many drivers already print information about setting a random mac
> address to a netdevice. Some with printk, some via
> netdev_warn/netdev_info/netdev_dbg or netif_dbg and other with costum
> methods. I could unify this, in a next step with a netdev_info in
> eth_hw_addr_random(), if it's okay for David.

i think unification in the core makes sense.  it enforces consistency and 
removes duplication.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)