netdev - Antwort: [patch] net/ethernet: ks8851_mll: signedness bug in ks8851

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF305A41EA.D95E3D10-ONC12579A7.002BCB7F-C12579A7.002C05CA@phytec.de>
Date:	Fri, 17 Feb 2012 09:00:51 +0100
From:	Jan Weitzel <J.Weitzel@...tec.de>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Danny Kukawka <danny.kukawka@...ect.de>,
	"David S. Miller" <davem@...emloft.net>,
	kernel-janitors@...r.kernel.org, netdev@...r.kernel.org,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Thomas Meyer <thomas@...3r.de>
Subject: Antwort: [patch] net/ethernet: ks8851_mll: signedness bug in ks8851_probe()

Dan Carpenter <dan.carpenter@...cle.com> schrieb am 17.02.2012 07:44:33:

> Von: Dan Carpenter <dan.carpenter@...cle.com>
> An: Jan Weitzel <j.weitzel@...tec.de>
> Kopie: Alexey Dobriyan <adobriyan@...il.com>, "David S. Miller" 
> <davem@...emloft.net>, Paul Gortmaker 
> <paul.gortmaker@...driver.com>, Thomas Meyer <thomas@...3r.de>, 
> Danny Kukawka <danny.kukawka@...ect.de>, netdev@...r.kernel.org, 
> kernel-janitors@...r.kernel.org
> Datum: 17.02.2012 07:45
> Betreff: [patch] net/ethernet: ks8851_mll: signedness bug in 
ks8851_probe()
> 
> netdev->irq is unsigned, so it's never less than zero.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Tested-by: Jan Weitzel <j.weitzel@...tec.de>

> diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/
> ethernet/micrel/ks8851_mll.c
> index 10d5798..b8104d9 100644
> --- a/drivers/net/ethernet/micrel/ks8851_mll.c
> +++ b/drivers/net/ethernet/micrel/ks8851_mll.c
> @@ -1544,7 +1544,7 @@ static int __devinit ks8851_probe(struct 
> platform_device *pdev)
> 
>     netdev->irq = platform_get_irq(pdev, 0);
> 
> -   if (netdev->irq < 0) {
> +   if ((int)netdev->irq < 0) {
>        err = netdev->irq;
>        goto err_get_irq;
>     }

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html