| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120217094110.GB12814@x220> Date: Fri, 17 Feb 2012 11:41:10 +0200 From: Johan Hedberg <johan.hedberg@...il.com> To: Marcel Holtmann <marcel@...tmann.org> Cc: Joe Perches <joe@...ches.com>, "Gustavo F. Padovan" <padovan@...fusion.mobi>, "David S. Miller" <davem@...emloft.net>, linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH V2 2/3] bluetooth: Convert BT_ERR/BT_INFO to bt_err/bt_info Hi, > > Use the more common kernel style functions rather than > > an upper case macro. > > > > Add newlines to end of formats. > > Coalesce formats, align arguments. > > > > Signed-off-by: Joe Perches <joe@...ches.com> > > --- > > drivers/bluetooth/ath3k.c | 46 +++++++------- > > drivers/bluetooth/bcm203x.c | 24 ++++---- > > drivers/bluetooth/bfusb.c | 67 +++++++++++--------- > > drivers/bluetooth/bluecard_cs.c | 17 +++--- > > drivers/bluetooth/bpa10x.c | 18 +++--- > > drivers/bluetooth/bt3c_cs.c | 36 ++++++----- > > drivers/bluetooth/btmrvl_debugfs.c | 2 +- > > drivers/bluetooth/btmrvl_main.c | 39 ++++++------ > > drivers/bluetooth/btmrvl_sdio.c | 122 +++++++++++++++++------------------- > > drivers/bluetooth/btsdio.c | 2 +- > > drivers/bluetooth/btuart_cs.c | 23 ++++--- > > drivers/bluetooth/btusb.c | 38 ++++++------ > > drivers/bluetooth/btwilink.c | 29 ++++----- > > drivers/bluetooth/dtl1_cs.c | 19 +++--- > > drivers/bluetooth/hci_ath.c | 6 +- > > drivers/bluetooth/hci_bcsp.c | 50 ++++++++------- > > drivers/bluetooth/hci_h4.c | 8 +- > > drivers/bluetooth/hci_ldisc.c | 14 ++-- > > drivers/bluetooth/hci_ll.c | 33 ++++++---- > > drivers/bluetooth/hci_vhci.c | 6 +- > > include/net/bluetooth/hci_core.h | 6 +- > > net/bluetooth/af_bluetooth.c | 4 +- > > net/bluetooth/bnep/core.c | 4 +- > > net/bluetooth/bnep/netdev.c | 2 +- > > net/bluetooth/bnep/sock.c | 4 +- > > net/bluetooth/cmtp/capi.c | 19 +++--- > > net/bluetooth/cmtp/core.c | 8 +- > > net/bluetooth/cmtp/sock.c | 4 +- > > net/bluetooth/hci_core.c | 24 ++++---- > > net/bluetooth/hci_event.c | 16 +++--- > > net/bluetooth/hci_sock.c | 6 +- > > net/bluetooth/hci_sysfs.c | 2 +- > > net/bluetooth/hidp/core.c | 14 +++-- > > net/bluetooth/hidp/sock.c | 4 +- > > net/bluetooth/l2cap_core.c | 32 +++++----- > > net/bluetooth/l2cap_sock.c | 6 +- > > net/bluetooth/mgmt.c | 6 +- > > net/bluetooth/rfcomm/core.c | 16 +++--- > > net/bluetooth/rfcomm/sock.c | 8 +- > > net/bluetooth/rfcomm/tty.c | 18 +++--- > > net/bluetooth/sco.c | 8 +- > > net/bluetooth/smp.c | 14 ++-- > > 42 files changed, 419 insertions(+), 405 deletions(-) > > I leave this up to Johan if he can get it merged without having to redo > the patch. Otherwise it might have to wait a little bit. > > If you would split drivers/ from include/ and net/ I think it has more > likelihood that at least that one can be merged easily. > > Acked-by: Marcel Holtmann <marcel@...tmann.org> Patches 2/3 and 3/3 have never actually made it to the linux-bluetooth list (I've never seen them and they're not visible in the archives either). Doing the split like Marcel proposes would probably solve the issue since I'm guessing the large message size is to blame. Johan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists