netdev - Re: [PATCH 4/6] NET: MIPS: lantiq: convert etop to managed gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F3E46F0.5010701@openwrt.org>
Date:	Fri, 17 Feb 2012 13:24:16 +0100
From:	John Crispin <blogic@...nwrt.org>
To:	John Crispin <blogic@...nwrt.org>
CC:	Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 4/6] NET: MIPS: lantiq: convert etop to managed gpio


>  	ltq_gbit_w32_mask(0, PX_CTL_DMDIO, LTQ_GBIT_P0_CTL);
> @@ -873,6 +870,12 @@ ltq_etop_probe(struct platform_device *pdev)
>  			err = -ENOMEM;
>  			goto err_out;
>  		}
> +		if (ltq_gpio_request(&pdev->dev, 42, 2, 1, "MDIO") ||
> +				ltq_gpio_request(&pdev->dev, 43, 2, 1, "MDC")) {
> +			dev_err(&pdev->dev, "failed to request MDIO gpios\n");
> +			err = -ENOMEM;
-EBUSY should go here instead of -ENOMEM


> +			goto err_out;
> +		}
>  	}
>  
>  	dev = alloc_etherdev_mq(sizeof(struct ltq_etop_priv), 4);

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html