netdev - Re: sysfs^H^H^H^H^Hsysctl warnings, reserved names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1aa4e5y0i.fsf@fess.ebiederm.org>
Date:	Sun, 19 Feb 2012 13:11:41 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Denys Fedoryshchenko <denys@...p.net.lb>, netdev@...r.kernel.org
Subject: Re: sysfs^H^H^H^H^Hsysctl warnings, reserved names

Eric Dumazet <eric.dumazet@...il.com> writes:

>> Well we are talking about sysctl not sysfs but same difference, I keep
>> an on eye on them.
>> 
>> I expect renaming a network device to "all" or "default" would be a
>> problem in any kernel supporting renaming of networking devices.
>> 
>> At the basic level of handling it.  sysctl checks for this sometimes
>> now and as soon as my sysctl tree is merged the checks will become
>> unconditionally present.  In what sense were you thinking it would
>> be better to address this in the sysctl?
>> 
>
> Because problem is : it seems a rename() of "eth3" to "default" is
> allowed by sysctl, yet "default" is already in directory.
>
> It seems sysfs_rename_link() / sysfs_rename_dir() / sysfs_rename() might
> have a problem ?

The files are under /proc/sys so we are talking about sysctls, which
means that the error is reported from register_net_sysctl_table.

The path is:
NETDEV_CHANGENAME
	devinet_sysctl_unregister() -> void
	devinet_sysctl_register() -> void
return NOTIFY_DONE;

Eric
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html