netdev - Re: [PATCH] netem: fix dequeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120219.190003.460010241580144655.davem@davemloft.net>
Date:	Sun, 19 Feb 2012 19:00:03 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] netem: fix dequeue

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 16 Feb 2012 07:28:25 +0100

> commit 50612537e9 (netem: fix classful handling) added two errors in
> netem_dequeue() 
> 
> 1) After checking skb at the head of tfifo queue for time constraints,
>    it dequeues tail skb, thus adding unwanted reordering.
> 
> 2) qdisc stats are updated twice per packet
>    (one when packet dequeued from tfifo, once when delivered)
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html