netdev - Re: [PATCH 4/6] sock: Introduce the SO_PEEK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120221.150531.8578951206190289.davem@davemloft.net>
Date:	Tue, 21 Feb 2012 15:05:31 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	xemul@...allels.com, netdev@...r.kernel.org
Subject: Re: [PATCH 4/6] sock: Introduce the SO_PEEK_OFF sock option

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 21 Feb 2012 18:45:50 +0100

> Le mardi 21 février 2012 à 21:31 +0400, Pavel Emelyanov a écrit :
>> This one specifies where to start MSG_PEEK-ing queue data from. When
>> set to negative value means that MSG_PEEK works as ususally -- peeks
>> from the head of the queue always.
>> 
>> When some bytes are peeked from queue and the peeking offset is non
>> negative it is moved forward so that the next peek will return next
>> portion of data.
>> 
>> When non-peeking recvmsg occurs and the peeking offset is non negative
>> is is moved backward so that the next peek will still peek the proper
>> data (i.e. the one that would have been picked if there were no non
>> peeking recv in between).
>> 
>> The offset is set using per-proto opteration to let the protocol handle
>> the locking issues and to check whether the peeking offset feature is
>> supported by the protocol the socket belongs to.
>> 
>> Signed-off-by: Pavel Emelyanov <xemul@...allels.com>
 ...
> 
> small note : should be moved down by one line, after SCM_WIFI_STATUS
> 
> Other than that, 

You also didn't update all of the arch/*/include/asm/socket.h files.

I took care of all of this, but what should have been a simple matter
of me typing "git am --signoff foo.mbox" and "make" turned into a
10 minute exercise in raking leaves. :-/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html