netdev - RE: [PATCH] rtnetlink: Fix problem with buffer allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Feb 2012 21:28:17 +0000
From:	"Rose, Gregory V" <gregory.v.rose@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] rtnetlink: Fix problem with buffer allocation

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of David Miller
> Sent: Tuesday, February 21, 2012 1:21 PM
> To: Rose, Gregory V
> Cc: netdev@...r.kernel.org
> Subject: Re: [PATCH] rtnetlink: Fix problem with buffer allocation
> 
> From: David Miller <davem@...emloft.net>
> Date: Tue, 21 Feb 2012 16:16:30 -0500 (EST)
> 
> >
> > Greg, where is the code that guards the actual dumping of the VF
> > information based upon the ext mask?
> >
> > I only see the ext mask controlling the sizing of the SKB.  What good
> > is that if we still dump the VFs?
> 
> Actually, it's even worse, this thing doesn't even compile because
> you haven't updated the actual implementation of rtnl_vfinfo_size()
> to take the new mask argument.
> 
> You didn't even compile test this, are you fucking kidding me?
> 
> net/core/rtnetlink.c: In function ʽif_nlmsg_sizeʼ:
> net/core/rtnetlink.c:789:9: error: too many arguments to function
> ʽrtnl_vfinfo_sizeʼ
> net/core/rtnetlink.c:726:19: note: declared here
> make[1]: *** [net/core/rtnetlink.o] Error 1
> make: *** [net/core/rtnetlink.o] Error 2

I compile tested it on my development machine and then exported it to a machine that can connect to the internet and mail patches.  I must have screwed something up at that point.

Let me see what the heck I did.

- Greg

> .θΊ{.nΗ+·+%Λlzwmιbλ§²ζμrΈzwuλβΨ^nrʽφ¦zΛ.λh¨θΪ&ʼψ.G«ιh.(
> ιέʼj"ϊ.Ά.m§οκδzΉήΰώf£ʼ·h§~m