netdev - RE: [PATCH] rtnetlink: Fix problem with buffer allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Feb 2012 21:56:14 +0000
From:	"Rose, Gregory V" <gregory.v.rose@...el.com>
To:	David Miller <davem@...emloft.net>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] rtnetlink: Fix problem with buffer allocation

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Tuesday, February 21, 2012 1:50 PM
> To: eric.dumazet@...il.com
> Cc: Rose, Gregory V; netdev@...r.kernel.org
> Subject: Re: [PATCH] rtnetlink: Fix problem with buffer allocation
> 
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Tue, 21 Feb 2012 22:48:16 +0100
> 
> > Thats going to hurt some setups (thousand of devices on a server).
> 
> This logic only triggers when the VF attribute is explicitly asked
> for.
> 
> > Also why are you using _rcu() variant here, we hold rtnl I presume ?
> 
> Because that's what I told him to use probably :-)  Indeed, I think
> we can use the non-RCU variant in this spot.

In rtnl_fill_ifinfo the code there uses hlist_for_each_entry_rcu() so I think that's why it got carried over here.  I can remove it.

- Greg

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html