[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20120221.175939.31025047537106310.davem@davemloft.net>
Date: Tue, 21 Feb 2012 17:59:39 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: davej@...hat.com
Cc: netdev@...r.kernel.org
Subject: Re: return 0 when MSG_OOB in ping_recvmsg
From: Dave Jones <davej@...hat.com>
Date: Tue, 21 Feb 2012 17:50:59 -0500
> If a packet causes the 'if (flags & MSG_OOB)' test this function does first
> thing is true, it returns an uninitialised variable from the stack.
>
> There may be a better return code for this failure, but returning
> '0 bytes copied' seems better than just returning garbage.
>
> Signed-off-by: Dave Jones <davej@...hat.com>
It should return something initialized, for sure, but more appropriate
is -EOPNOTSUPP as is consistent with this file's sendsmg() implementation
as well as the sendmsg and recvmsg methods from net/ipv4/raw.c upon which
these were modelled.
So that's the change I'll commit, thanks Dave!
--------------------
ipv4: ping: Fix recvmsg MSG_OOB error handling.
Don't return an uninitialized variable as the error, return
-EOPNOTSUPP instead.
Reported-by: Dave Jones <davej@...hat.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
---
net/ipv4/ping.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c
index aea5a19..b072386 100644
--- a/net/ipv4/ping.c
+++ b/net/ipv4/ping.c
@@ -630,6 +630,7 @@ static int ping_recvmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg,
pr_debug("ping_recvmsg(sk=%p,sk->num=%u)\n", isk, isk->inet_num);
+ err = -EOPNOTSUPP;
if (flags & MSG_OOB)
goto out;
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists