netdev - Re: [PATCH] cdc_ether/zaurus: Move Harmony 900 from cdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.02.1202201943040.31081@bear.techie.net>
Date:	Mon, 20 Feb 2012 19:50:57 -0500 (EST)
From:	Scott Talbert <talbert@...hie.net>
To:	David Miller <davem@...emloft.net>
cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] cdc_ether/zaurus: Move Harmony 900 from cdc_ether to
 zaurus

On Mon, 20 Feb 2012, David Miller wrote:

> From: Scott Talbert <talbert@...hie.net>
> Date: Sun, 19 Feb 2012 20:35:29 -0500 (EST)
>
>> The Logitech Harmony 900 remote control appears to use the pseudo-MDLM
>> driver, rather than the standard one.  This patch simply moves the
>> device so that it gets picked up by the correct driver.
>>
>> Signed-off-by: Scott Talbert <talbert@...hie.net>
>
> You're not moving anything, you're adding the ID to not one but two
> different drivers.
>
> That doesn't make any sense to me, so either this patch is completely
> wrong or you need to rewrite your commit message to explain things
> better and more accurately.

Sorry, to clarify...in the current baseline, the Harmony 900 gets picked 
up by the cdc_ether driver by this generic line in cdc_ether.c:

 	USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_MDLM,
 			USB_CDC_PROTO_NONE),
 	.driver_info = (unsigned long)&wwan_info,

The intent of my patch is to blacklist the Harmony 900 from cdc_ether and 
whitelist it in zaurus.

Scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html