[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120222.145028.911050172843464062.davem@davemloft.net>
Date: Wed, 22 Feb 2012 14:50:28 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: piergiorgio.beruto@...il.com, netdev@...r.kernel.org,
mtk.manpages@...il.com
Subject: Re: [PATCH net-next] af_unix: MSG_TRUNC support for dgram sockets
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 22 Feb 2012 10:24:55 +0100
> Piergiorgio Beruto expressed the need to fetch size of first datagram in
> queue for AF_UNIX sockets and suggested a patch against SIOCINQ ioctl.
>
> I suggested instead to implement MSG_TRUNC support as a recv() input
> flag, as already done for RAW, UDP & NETLINK sockets.
>
> len = recv(fd, &byte, 1, MSG_PEEK | MSG_TRUNC);
>
> MSG_TRUNC asks recv() to return the real length of the packet, even when
> is was longer than the passed buffer.
>
> There is risk that a userland application used MSG_TRUNC by accident
> (since it had no effect on af_unix sockets) and this might break after
> this patch.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Tested-by: Piergiorgio Beruto <piergiorgio.beruto@...il.com>
> CC: Michael Kerrisk <mtk.manpages@...il.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists