lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <804857E1F29AAC47BF68C404FC60A18429B98A@ORSMSX102.amr.corp.intel.com> Date: Wed, 22 Feb 2012 02:17:46 +0000 From: "Allan, Bruce W" <bruce.w.allan@...el.com> To: Joe Perches <joe@...ches.com> CC: David Miller <davem@...emloft.net>, Andy Whitcroft <apw@...dowen.org>, Andrew Morton <akpm@...ux-foundation.org>, "andrei.emeltchenko.news@...il.com" <andrei.emeltchenko.news@...il.com>, "linville@...driver.com" <linville@...driver.com>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] checkpatch: Add some --strict coding style checks > -----Original Message----- > From: Joe Perches [mailto:joe@...ches.com] > Sent: Tuesday, February 21, 2012 5:59 PM > To: Allan, Bruce W > Cc: David Miller; Andy Whitcroft; Andrew Morton; > andrei.emeltchenko.news@...il.com; linville@...driver.com; linux- > wireless@...r.kernel.org; netdev@...r.kernel.org; linux- > kernel@...r.kernel.org > Subject: RE: [PATCH] checkpatch: Add some --strict coding style checks > > On Wed, 2012-02-22 at 01:56 +0000, Allan, Bruce W wrote: > > > On Tue, 2012-02-21 at 22:09 +0000, Allan, Bruce W wrote: > > > > This appears to falsely complain about parenthesis alignment in > > > > conditional statements with multiple opening parentheses. > > > Can you try this one please? > [] > > It's better, but there are still instances of false hits AFAICT. > > Do you have any examples? > The only one I noticed was spaces for alignment instead of tabs. > I think that's not a false hit myself. > Example 1: if (((a == b) || (c == d) || (e == f)) && (bool_var)) baz(); Example 2: if ((!(var & FOO_MASK) && (a == b)) || (c == d)) baz(); Example 3: if (!((foo & FOO_MASK) && (bar & BAR_MASK))) baz(); HTH, Bruce.
Powered by blists - more mailing lists