netdev - Re: [PATCH 1/2] netdev/phy/icplus: Correct broken phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120223.171439.490391422998418894.davem@davemloft.net>
Date:	Thu, 23 Feb 2012 17:14:39 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org, david.mckay@...com
Subject: Re: [PATCH 1/2] netdev/phy/icplus: Correct broken phy_init code

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Wed, 22 Feb 2012 08:24:57 +0100

> From: David McKay <david.mckay@...com>
> 
> The code for ip1001_config_init() was totally broken if you were not
> using RGMII. Instead of returning an error code or zero it actually
> returned the value in the IP1001_SPEC_CTRL_STATUS_2 register. It was
> also trying to set the IP1001_APS_ON bit , but never actually wrote
> back the register.
> 
> The error checking was also incorrect in both this function and the
> reset function, so this patch fixes that up in a consistent fashion.
> 
> Signed-off-by: David McKay <david.mckay@...com>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html