lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 23 Feb 2012 12:39:10 +0000 From: "Rajashekhara, Sudhakar" <sudhakar.raj@...com> To: Christian Riesch <christian.riesch@...cron.at>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> CC: "davinci-linux-open-source@...ux.davincidsp.com" <davinci-linux-open-source@...ux.davincidsp.com>, Sascha Hauer <s.hauer@...gutronix.de>, "stable@...r.kernel.org" <stable@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: RE: [PATCH v2] davinci_emac: Do not free all rx dma descriptors during init Hi, On Thu, Feb 23, 2012 at 16:44:17, Christian Riesch wrote: > This patch fixes a regression that was introduced by > > commit 0a5f38467765ee15478db90d81e40c269c8dda20 > davinci_emac: Add Carrier Link OK check in Davinci RX Handler > > Said commit adds a check whether the carrier link is ok. If the link is > not ok, the skb is freed and no new dma descriptor added to the rx dma > channel. This causes trouble during initialization when the carrier > status has not yet been updated. If a lot of packets are received while > netif_carrier_ok returns false, all dma descriptors are freed and the > rx dma transfer is stopped. > > The bug occurs when the board is connected to a network with lots of > traffic and the ifconfig down/up is done, e.g., when reconfiguring > the interface with DHCP. > > The bug can be reproduced by flood pinging the davinci board while doing > ifconfig eth0 down > ifconfig eth0 up > on the board. > > After that, the rx path stops working and the overrun value reported > by ifconfig is counting up. > > This patch reverts commit 0a5f38467765ee15478db90d81e40c269c8dda20 > and instead issues warnings only if cpdma_chan_submit returns -ENOMEM. > > Signed-off-by: Christian Riesch <christian.riesch@...cron.at> > Cc: <stable@...r.kernel.org> > Cc: Hegde, Vinay <vinay.hegde@...com> > Cc: Cyril Chemparathy <cyril@...com> > Cc: Sascha Hauer <s.hauer@...gutronix.de> > --- > > Hi, > Since my first submission of this patch yesterday I did additional tests > with suspend/rtcwake. My tests confirmed that the solution in this > patch solves the problem that was addressed by commit > 0a5f38467765ee15478db90d81e40c269c8dda20 while not destroying the > rx communication channel. > Tested on DA850 and confirmed that there is no regression. Tested-by: Rajashekhara, Sudhakar <sudhakar.raj@...com> Regards, Sudhakar -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists