[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1330011962.5143.50.camel@joe2Laptop>
Date: Thu, 23 Feb 2012 07:46:02 -0800
From: Joe Perches <joe@...ches.com>
To: "N, Mugunthan V" <mugunthanvnm@...com>,
Andy Whitcroft <apw@...dowen.org>
Cc: "davem@...emloft.net" <davem@...emloft.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH v2 2/2] netdev: driver: ethernet: Add TI CPSW driver
On Thu, 2012-02-23 at 12:47 +0000, N, Mugunthan V wrote:
> Joe/David
> > > -----Original Message-----
> > > From: Joe Perches [mailto:joe@...ches.com]
> > > Sent: Tuesday, February 21, 2012 4:34 AM
> [...]
> > > Add
> > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > > before all #includes and remove the embedded prefix
> > > from all pr_<level> uses.
> > Agreed, will make use of pr_fmt and remove embedded prefix in pr_<level>
> > uses
> Adding
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> in the driver gives a checkpatch error as follows
> #77: FILE: drivers/net/ethernet/ti/cpsw.c:16:
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> total: 1 errors, 0 warnings, 1137 lines checked
> Is it ok to ignore the checkpatch error as most of the drivers use it.
Yes.
Andy Whitcroft has a pending checkpatch fix
for this. I hope he pushes it out soon.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists