netdev - Re: [Bug 42809] New: kernel panic when receiving an ipsec packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120223.151115.1646872434333284038.davem@davemloft.net>
Date:	Thu, 23 Feb 2012 15:11:15 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	darkbasic@...uxsystems.it, netdev@...r.kernel.org,
	openadsl-users@...ts.sourceforge.net,
	openadsl-devel@...ts.sourceforge.net, 660804@...s.debian.org,
	support@...verse.com.au, support@...ksolidelectronics.com
Subject: Re: [Bug 42809] New: kernel panic when receiving an ipsec packet

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 23 Feb 2012 15:36:26 +0100

> [PATCH] ipsec: be careful of non existing mac headers
> 
> Nicollo Belli reported ipsec crashes in case we handle a frame without
> mac header (atm in his case)
> 
> Before copying mac header, better make sure it is present.
> 
> Bugzilla reference:  https://bugzilla.kernel.org/show_bug.cgi?id=42809
> 
> Reported-by: Niccolò Belli <darkbasic@...uxsystems.it>
> Tested-by: Niccolò Belli <darkbasic@...uxsystems.it>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Three instances of the same piece of code, maybe a helper function is
appropriate at that point? :-) You might even get ambitious and add a
big comment to that helper function explaining the situation.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html