netdev - Re: [PATCH net-next 2/3] mlx4_en: moderate frequency of TX completions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120223.164642.1510847570351068406.davem@davemloft.net>
Date:	Thu, 23 Feb 2012 16:46:42 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	yevgenyp@...lanox.co.il, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] mlx4_en: moderate frequency of TX
 completions

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Thu, 23 Feb 2012 21:13:56 +0000

> On Thu, 2012-02-23 at 14:44 -0500, David Miller wrote:
>> From: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
>> Date: Thu, 23 Feb 2012 15:34:27 +0200
>> 
>> > No need to ask for completion for every packet being sent.
>> > So the method is to ask for a completion every 16 packets,
>> > or when the queue is about to be full.
>> > 
>> > Signed-off-by: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
>> 
>> You absolutely cannot do this, you must signal completion and free up
>> TX queue packets in a finite amount of time.
> 
> Really, sfc has been doing this forever.

You have to stop, because otherwise sockets can hang since those
packets can hold a reference to the socket so they must be
released in a finite amount of time regardless of network
traffic.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html