netdev - RE: davinci_emac/mdio: SOFT_RESET of EMAC module resets MDIO on AM1808

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B6A220404B6BFC4BBD2AB91C54D39DF431775E1B@DBDE01.ent.ti.com>
Date:	Fri, 24 Feb 2012 13:02:00 +0000
From:	"Rajashekhara, Sudhakar" <sudhakar.raj@...com>
To:	Christian Riesch <christian.riesch@...cron.at>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"Chemparathy, Cyril" <cyril@...com>,
	"Gole, Anant" <anantgole@...com>
Subject: RE: davinci_emac/mdio: SOFT_RESET of EMAC module resets MDIO on
 AM1808

Hi Christian,

On Thu, Feb 23, 2012 at 14:39:49, Christian Riesch wrote:
> Hi,
> I observed this behavior on a Texas Instruments AM1808 SoC (AM1808
> experimenter's kit) running the current mainline kernel:
> 
> # ifconfig eth0 down
> # ifconfig eth0 up
> davinci_mdio davinci_mdio.0: resetting idled controller
> net eth0: attached PHY driver [Generic PHY] (mii_bus:phy_addr=davinci_mdio-0:00)
> # PHY: davinci_mdio-0:00 - Link is Up - 100/Full
> 

I also observed this issue with the kernel from linux-davinci tree from
gitorious.

> After each ifconfig eth0 up I get this 'resetting idled controller'
> warning. I added a few debug messages to the davinci_mdio driver and
> noticed that the MDIO control register was set to its reset value
> (clock divider 0xff and MDIO turned off) after an ifconfig eth0 up.
> Therefore, this warning is issued and a reconfiguration of the MDIO
> controller is done by the driver.
> 
> Now the question was: Who is turning off the MDIO controller? After a
> bit of debugging I found out that the reset of the MDIO controller
> seems to be caused by these lines in the davinci_emac driver in
> emac_hw_enable() in drivers/net/ethernet/ti/davinci_emac.c:
> 
> emac_write(EMAC_SOFTRESET, 1);
> while (emac_read(EMAC_SOFTRESET))
>         cpu_relax();
> 
> According to the AM1808 Technical Reference Manual (sections 18.2.14.1
> and 18.3.3.34 in [1]), writing a 1 to the EMAC_SOFTRESET register
> resets the EMAC module, but not the MDIO module. However, when I
> comment out the code above, the MDIO control register is not affected
> and the warning 'resetting idled controller' disappears.
> 

But this was not the case for me. Even after commenting out the above lines,
I could still see that MDIO was getting reset.

During eth0 up, the smsc_phy_config_init() function calls the mdiobus_read()
function. During this sequence if the MDIO state machine is in IDLE state,
then MDIO is reset causing the above warning message to appear.

In summary, EMAC reset is not causing the MDIO reset to happen.

Thanks,
Sudhakar
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html