netdev - Re: [PATCH 00/12] Part 2: check given MAC address, if invalid return -EADDRNOTAVAIL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHXqBFK=u+MchBn=D31h6nhp-R9GTNbaC18QJA937zjXc60UQw@mail.gmail.com>
Date:	Fri, 24 Feb 2012 18:59:04 +0100
From:	Michał Mirosław <mirqus@...il.com>
To:	Danny Kukawka <danny.kukawka@...ect.de>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Andy Gospodarek <andy@...yhouse.net>,
	Guo-Fu Tseng <cooldavid@...ldavid.org>,
	Petko Manolov <petkan@...rs.sourceforge.net>,
	"VMware, Inc." <pv-drivers@...are.com>,
	"John W. Linville" <linville@...driver.com>, linux390@...ibm.com,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Danny Kukawka <dkukawka@...e.de>,
	Stephen Hemminger <shemminger@...tta.com>,
	Joe Perches <joe@...ches.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Jiri Pirko <jpirko@...hat.com>, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-wireless@...r.kernel.org,
	libertas-dev@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-hams@...r.kernel.org, linux-mips@...ux-mips.org
Subject: Re: [PATCH 00/12] Part 2: check given MAC address, if invalid return -EADDRNOTAVAIL

2012/2/24 Danny Kukawka <danny.kukawka@...ect.de>:
> Second Part of series patches to unifiy the return value of
> .ndo_set_mac_address if the given address isn't valid.
>
> These changes check if a given (MAC) address is valid in
> .ndo_set_mac_address, if invalid return -EADDRNOTAVAIL
> as eth_mac_addr() already does if is_valid_ether_addr() fails.

Why not just fix dev_set_mac_address() and make do_setlink() use that?
Checks are specific to address family, not device model I assume.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html