lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 24 Feb 2012 18:59:04 +0100
From:	Michał Mirosław <>
To:	Danny Kukawka <>
Cc:	"David S. Miller" <>,
	Andy Gospodarek <>,
	Guo-Fu Tseng <>,
	Petko Manolov <>,
	"VMware, Inc." <>,
	"John W. Linville" <>,,
	Mauro Carvalho Chehab <>,
	Danny Kukawka <>,
	Stephen Hemminger <>,
	Joe Perches <>,
	Jeff Kirsher <>,
	Jiri Pirko <>,,,,,,,,,
Subject: Re: [PATCH 00/12] Part 2: check given MAC address, if invalid return -EADDRNOTAVAIL

2012/2/24 Danny Kukawka <>:
> Second Part of series patches to unifiy the return value of
> .ndo_set_mac_address if the given address isn't valid.
> These changes check if a given (MAC) address is valid in
> .ndo_set_mac_address, if invalid return -EADDRNOTAVAIL
> as eth_mac_addr() already does if is_valid_ether_addr() fails.

Why not just fix dev_set_mac_address() and make do_setlink() use that?
Checks are specific to address family, not device model I assume.

Best Regards,
Michał Mirosław
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists