netdev - Re: [PATCH 1/3] netlink: add netlink_dump_control structure for netlink_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.01.1202250210240.17151@frira.zrqbmnf.qr>
Date:	Sat, 25 Feb 2012 02:12:22 +0100 (CET)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	pablo@...filter.org
cc:	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [PATCH 1/3] netlink: add netlink_dump_control structure for
 netlink_dump_start()

On Saturday 2012-02-25 01:30, pablo@...filter.org wrote:

>From: Pablo Neira Ayuso <pablo@...filter.org>
>
>Davem considers that the argument list of this interface is getting
>out of control. This patch tries to address this issue following
>his proposal:
>
>struct netlink_dump_control c = { .dump = dump, .done = done, ... };
>
>netlink_dump_start(..., &c);

What about adding skb and nlh into c as well? After all, skb
is not nearly as much {used directly} as it is in Xtables.

>+		{
>+			struct netlink_dump_control c = {
>+				.dump = link->dump,
>+				.done = link->done,
>+			};
>+			return netlink_dump_start(crypto_nlsk, skb, nlh, &c);
>+		}

You can also use

		return netlink_dump_start(crypto_nlsk, skb,
		       &(const struct netlink_dump_control)
		       {.dump = link->dump, .done = link->done}));
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html