netdev - Re: [PATCH net] sfc: Fix assignment of ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1330149676.2462.28.camel@edumazet-laptop>
Date:	Sat, 25 Feb 2012 07:01:16 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-net-drivers@...arflare.com
Subject: Re: [PATCH net] sfc: Fix assignment of ip_summed for pre-allocated
 skbs

Le samedi 25 février 2012 à 01:12 +0000, Ben Hutchings a écrit :
> When pre-allocating skbs for received packets, we set ip_summed =
> CHECKSUM_UNNCESSARY.  We used to change it back to CHECKSUM_NONE when
> the received packet had an incorrect checksum or unhandled protocol.
> 
> Commit bc8acf2c8c3e43fcc192762a9f964b3e9a17748b ('drivers/net: avoid
> some skb->ip_summed initializations') mistakenly replaced the latter
> assignment with a DEBUG-only assertion that ip_summed ==
> CHECKSUM_NONE.  This assertion is always false, but it seems no-one
> has exercised this code path in a DEBUG build.
> 
> Fix this by moving our assignment of CHECKSUM_UNNECESSARY into
> efx_rx_packet_gro().
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> ---

Ah, I'm sorry I missed this.

Thanks !


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html