netdev - Re: [PATCH net-next] mlx4_en: dont change mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120226.142723.2089903339861181922.davem@davemloft.net>
Date:	Sun, 26 Feb 2012 14:27:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eugenia@...lanox.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org,
	yevgenyp@...lanox.com
Subject: Re: [PATCH net-next] mlx4_en: dont change mac_header on xmit

From: Eugenia Emantayev <eugenia@...lanox.com>
Date: Sun, 26 Feb 2012 19:12:12 +0000

> From: Eric Dumazet [mailto:eric.dumazet@...il.com]
> Sent: Saturday, February 25, 2012 12:51 PM
> 
>> A driver xmit function is not allowed to change skb without special
>> care.
>>
>> mlx4_en_xmit() should not call skb_reset_mac_header() and instead should
>> use skb->data to access ethernet header.
>>
>> This removes a dumb test : if (ethh && ethh->h_dest)
>>
>> Also remove this slow mlx4_en_mac_to_u64() call, we can use
>> get_unaligned() to get faster code.
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
>> Cc: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
>> ---
>> Please test this patch before we can commit it, thanks !
> 
> Tested and approved, thanks.
> --

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html