netdev - Re: [PATCH v2] ARM: LPC32xx: Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120226015217.GA3257@tarshish>
Date:	Sun, 26 Feb 2012 03:52:18 +0200
From:	Baruch Siach <baruch@...s.co.il>
To:	Roland Stigge <stigge@...com.de>
Cc:	davem@...emloft.net, jeffrey.t.kirsher@...el.com,
	alexander.h.duyck@...el.com, eilong@...adcom.com,
	ian.campbell@...rix.com, netdev@...r.kernel.org,
	w.sang@...gutronix.de, linux-kernel@...r.kernel.org,
	kevin.wells@....com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] ARM: LPC32xx: Ethernet driver

Hi Roland,

On Sat, Feb 25, 2012 at 09:21:44PM +0100, Roland Stigge wrote:
> This patch adds an ethernet driver for the LPC32xx ARM SoC.
> 
> Signed-off-by: Roland Stigge <stigge@...com.de>

[snip]

> +static int __init ethaddr(char *s)
> +{
> +	int i;
> +	unsigned int r[6];
> +
> +	sscanf(s, "%x:%x:%x:%x:%x:%x",
> +			&r[0], &r[1], &r[2], &r[3], &r[4], &r[5]);
> +	for (i = 0; i < 6; i++)
> +		mac_address[i] = (u8)r[i];
> +
> +	return 1;
> +}
> +__setup("ethaddr=", ethaddr);

Please use a module_param() instead of a top level kernel parameter.

You may also consider using module_param_array() here. See 
drivers/net/ethernet/freescale/fec.c for an example. Note, however, that this 
changes the format the MAC address representation. Instead of 
"01:02:03:04:05:06", use "0x01,0x02,0x03,0x04,0x05,0x06".

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html