netdev - Re: [PATCH] tcp: fix tcp_shifted_skb() adjustment of lost_cnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1202280127490.17924@melkinpaasi.cs.helsinki.fi>
Date:	Tue, 28 Feb 2012 01:39:50 +0200 (EET)
From:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
To:	David Miller <davem@...emloft.net>, ncardwell@...gle.com,
	Greg KH <gregkh@...e.de>
cc:	Netdev <netdev@...r.kernel.org>, nanditad@...gle.com,
	ycheng@...gle.com, therbert@...gle.com, subramanian.vijay@...il.com
Subject: Re: [PATCH] tcp: fix tcp_shifted_skb() adjustment of lost_cnt_hint
 for FACK

On Tue, 14 Feb 2012, David Miller wrote:

> From: Neal Cardwell <ncardwell@...gle.com>
> Date: Tue, 14 Feb 2012 01:22:08 -0500
> 
> > This commit ensures that lost_cnt_hint is correctly updated in
> > tcp_shifted_skb() for FACK TCP senders. The lost_cnt_hint adjustment
> > in tcp_sacktag_one() only applies to non-FACK senders, so FACK senders
> > need their own adjustment.
> > 
> > This applies the spirit of 1e5289e121372a3494402b1b131b41bfe1cf9b7f -
> > except now that the sequence range passed into tcp_sacktag_one() is
> > correct we need only have a special case adjustment for FACK.
> > 
> > Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> 
> Applied, and queued up for -stable, thanks Neil.

There has been lots of TCP related warnings posted recently to netdev.
Finding out which of these three recent changes caused which warning and 
if they're all cured by the full series is bit challenging. ...IMHO we 
should wait a bit more until these recent fixes are put to stable in order 
to verify that the dust has really settled.


-- 
 i.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html