netdev - RE: [net-next 02/11] e1000e: cleanup: rename e1000e_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B6E7C@saturn3.aculab.com>
Date:	Mon, 27 Feb 2012 10:25:39 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>, <davem@...emloft.net>
Cc:	"Bruce Allan" <bruce.w.allan@...el.com>, <netdev@...r.kernel.org>,
	<gospo@...hat.com>, <sassmann@...hat.com>
Subject: RE: [net-next 02/11] e1000e: cleanup: rename e1000e_setup_link() and call as function pointer

 
> From: Bruce Allan <bruce.w.allan@...el.com>
> 
> Rename e1000e_setup_link() to e1000e_setup_link_generic() to signify
the
> function is used for more than one MAC-family type.  The 82571-family
has
> a custom setup_link function which also calls the generic function.
The
> ich8lan-family has a custom function which should just be called via
the
> function pointer.  The 80003es2lan-family just uses the generic
function.

Wouldn't it be better to add a suffix to the family-specific
functions instead of adding a lot of unnecessary churn?

	David


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html